Good morning team! Just pushed the latest API changes to staging. Can everyone take a look when you get a chance?
Looks great! I tested the authentication flow and everything works smoothly. The response times are much better now. 🚀
I've updated the design specs for the new dashboard. Here's the latest mockup:
dashboard-mockup.png
1.8 MB
The design looks amazing, Emma! One small thing - can we increase the contrast on the sidebar text? It might be hard to read in light mode.
Good catch, James! I'll bump up the contrast ratio. Should have an updated version by this afternoon.
Quick update - the staging deploy is live now. I also fixed that edge case with the token refresh. @Marcus can you verify on your end?
Just checked - token refresh is working perfectly now. No more 401s on long sessions. Nice work Sarah!
Hey team, reminder that we have the sprint retro at 2pm today. Please add your items to the board before then.
Sprint 24 - Retro Board
FigJam
Thanks for the reminder! I've added my items already. Also, can someone review my PR #247? It's the new search feature.
I'll take a look at that PR after lunch, Sarah. Also wanted to flag - we should probably add rate limiting to the new search endpoint before it goes live.
Good point on rate limiting. I actually have a middleware for that we used on the analytics service - I can share the code.
app.UseRateLimiter(options => {
options.GlobalLimiter = ...
});
Updated the sidebar contrast - here's the before/after comparison. Let me know if this works better!
sidebar-contrast-comparison.png
2.4 MB
That's so much better! The difference is really noticeable in light mode now. Ship it! 🎨
Back from lunch. @Marcus great idea on the rate limiting - let's add that to the sprint backlog. @James can you open a ticket for it?
Reviewed PR #247 - left a few comments but overall looks solid. Just a couple of edge cases around empty query strings we should handle.
Hey everyone! Just joined the channel. I'm starting on the QA team next week. Looking forward to working with all of you! 👋
Welcome aboard, Ava! 🙌 Ticket for rate limiting is created - SPRINT-892. I also linked James's middleware snippet in the description.
Welcome Ava! 🎉 Feel free to reach out if you need anything. Also - retro starts in 10 mins, everyone head over to the FigJam board!